App crashes on start with bogus MIDI mapping file

Bug Reports
1

NOTE: Please use the search function above before posting to avoid creating duplicate topics.

  • Device model (e.g. 2020 iPad Air 4th Gen): M1 MBP
  • Version of operating system (e.g. macOS 14.4.1): Latest
  • Version of djay (e.g. 5.1.2): Latest
  • Hardware/controllers used (e.g. Reloop Mixon 8 Pro): Any MIDI device

Summary of the issue:
When a MIDI mapping file has any problem (e.g.: PLIST structure problem), which could happen to anyone trying to customise them by hand, the application will simply crash upon load.

How to reproduce the issue:
1-create a simple MIDI mapping file
2-intentionally break it in any way (e.g.: delete a class closing line)
3-open the application

It would be nice to get something like “corrupt midi mapping file detected - configuration won’t load” instead of flat out crashing the whole application.

Also the MIDI mapping handling is very poor - we still don’t have an official import/export feature. I’ve spend hours improving my mapping and I believe many other DJs do the same, these files are important to us.

2

Hi @palestina, sorry to hear you’re experiencing this issue. Thanks for sharing this issue. To help us troubleshoot this crash, please submit an Official Support Ticket using the procedure below so the engineering team can review your crash reports in more detail.

  1. Open the djay Pro app on your Mac.
  2. In the top left corner of your screen, click on the portion of the menu bar that says “djay Pro”.
  3. In the drop-down menu, click on the button that says “Provide djay Pro Feedback”.
  4. Fill out the submission form that will pop up in your default browser and title your email "ATTN: MARIE – “The Title of your Community Topic” in the provided subject line.

As I won’t have access to your crash report, I’ll consider this community topic solved for now and let the official support team take over from here. However, feel free to share any other details about your crash here that you think will be helpful in diagnosing the issue. Thanks!

5

I’ll do that later today!
Should be super easy to repro, though.
Just create a single button mapping from a MIDI device, close the application, edit with vi or whatever to make it bogus (e.g.: remove a </> closing line), then open the application again - it will crash upon load without telling you that the problem is just a corrupt MIDI mapping file.

6

For our fellow users bumping into this in the future:

Workaround:
Fix your config file with an XML PLIST editor, or simply move it outside of the default location so that the application won’t be able to read it when it starts. That way you can at least open the application again.